Back to top

My first Drupal Patch

Shortly after reading Steve Dondley's message about giving credit for Drupal commits I actually made a patch for a problem with node preview that got committed. You can see the commit message in cvs log for node.module

There it is:

revision 1.613
date: 2006-03-09 21:59:43 +0000;  author: killes;  state: Exp;  lines: +2 -2;  commitid: 51f74410a5114567;
#52586, node preview broken with php5, patch by greggles

Simple, but yeah, it did make me happy.

Also, note that I didn't actually find the problem or the solution, I just created the actual patch file. While I'm on that subject it's worth mentioning a couple of points:

Lots of people go around demanding changes to open source projects or getting upset that their pet bug hasn't gotten the attention they feel is appropriate. If you have a pet patch and you can't code, you can at least:

  • Make sure that your description of the bug includes concrete steps to repeat the problem.
  • If appropriate, create a simplified test case and/or script to recreate the problem.
  • If you know in the code where the change is, don't just explain what to do or paste code into the bug, but actually create a patch file.
  • Make sure all of the flags in the bug description are approriate such as component, severity, etc.
  • Advertise your bug - put it in your forum signature, in your email signature on the email account that goes to related mailing lists, stick it on your website, but publicize the bug so others can see it and help

If you do those things and the bug is still ignored then either your bug isn't really a problem or the project is dead.

People Involved: 


Technically speaking, this

Technically speaking, this patch to xstatistics was my first patch that landed in the Drupal CVS repository, but I never checked the log to see if it was committed. It was:

Revision 1.4 - (view) (download) (annotate) - [select for diffs]
Tue Jan 10 09:29:54 2006 UTC (2 months, 2 weeks ago) by ber
Branch: MAIN
Changes since 1.3: +15 -8 lines
Diff to previous 1.3

32662 patch to make summary aware of user settings. Do not show cuont if counter is disabled.

Sadly, Ber forgot my name in the log. I guess I'll get over it.